Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect missing-translation warnings in
scripts/validate_all.py.Problem
Language configuration files use the following mapping structure:
native_identifier -> python_identifierHowever, the validator incorrectly checks whether Python keywords and built-in function names exist as dictionary keys, rather than values.
Consequently, valid translations are incorrectly reported as missing.
Root Cause
The original implementation:
Checks dictionary keys instead of translated values.
The corrected implementation:
Correctly identifies whether a Python identifier has a corresponding native-language translation.
Changes
Testing
Environment: Windows 11 ARM64, Python 3.14.
Validation command:
py .\scripts\validate_all.pyResults
The difference in language count is expected because Bulgarian is maintained in a separate feature branch.
Remaining warning:
zh.json: Missing builtins translation: idThis warning identifies an actual missing translation in the Chinese language configuration.
Additional Checks
git diff --check): PASSED.Scope
This fix is language-independent and does not modify any language configuration files.
It corrects the validator's logic while preserving its existing validation behaviour.