Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
There was a problem hiding this comment.
🟡 Changes recommended
The pinned dependency lacks the required link support, and the proposed links would also lack a persistent visual indicator.
2 open issues
What changed in this PR
Adds permission-aware summit-name links to the directory, using uicore’s linked-cell API to navigate to summit editing.
Changes:
- Configures name links only for users who can edit summits.
- Routes plain clicks through
history.push, delegating modified-click behavior to uicore. - Shares edit and dashboard URL helpers with existing navigation handlers.
| File | Description |
|---|---|
src/pages/summits/summit-directory-page.js |
Adds conditional name links, navigation handling, and shared URL helpers. |
Review effort: Balanced
| { | ||
| columnKey: "name", | ||
| header: T.translate("directory.summit_name"), | ||
| getHref: canEditSummit ? summitEditUrl : undefined, |
| getHref: canEditSummit ? summitEditUrl : undefined, | ||
| render: (row) => ( | ||
| <> | ||
| <div>{row.name}</div> |
ako3131
force-pushed
the
feat/add-linkable-cells
branch
from
November 13, 2026 22:34
f3bedc9 to
ac812f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/9014802374/86bcxpx52
Summary
Summit names on the summit directory page are now links to the summit's edit page. They use the new linkable cells from uicore (OpenStackweb/openstack-uicore-foundation#381).
getHref, but only when the user can edit summits. Otherwise it stays plain text.onNavigatesends plain clicks throughhistory.push, so there's no page reload. Ctrl/Cmd-click and middle-click still open a new tab.summitEditUrl/summitDashboardUrl, so the link and the existing handlers share them.Depends on
uicore#381 merged and published, plus an
openstack-uicore-foundationversion bump in this PR.