[dnyw4l3n13]

Groups cloudformation.json Mappings under Mappings.Deployment.<Group>.<Key> to match funfair-treasury-reporting, following the plan on #435. Resolved values are unchanged. README and CHANGELOG updated accordingly.

Closes #435

[credfeto]

Roslyn analyzer findings

Source	Rule	Level	File	Line	Suppressed	Message
DotNet	CA2000	error	src/BuildBot/Helpers/ServerStartup.cs	99	yes	Call System.IDisposable.Dispose on object created by 'CreateLogger()' before all references to it are out of scope

[dnyw4l3n13]

Pre-commit end-of-file-fixer fails on .gitignore (extra trailing blank line, already on main; this PR does not touch it). My fix commit was rejected by the commit hook: "Linter/style config files cannot be added, changed, or deleted: .gitignore". I did not bypass it and reverted the change, so the PR is unchanged. The required CI checks pass. A human needs to decide whether to fix the trailing blank line in .gitignore separately. The Roslyn CA2000 finding is already suppressed and is in a file this PR does not change. The board stays at Development.

[dnyw4l3n13]

Implemented #435 in 02214c7 (cloudformation.json regrouped under Mappings.Deployment, README updated) and d490224 (changelog). Resolved values verified identical, cfn-lint clean, pre-commit passed. Next: wait for CI, then simplify.

[dnyw4l3n13]

Simplify clean — advancing to code review. (No changes made; the .gitignore end-of-file pre-commit failure is pre-existing on main and left for a human, as noted above.)

[dnyw4l3n13]

Code review clean — advancing to security review. (Every FindInMap reference points at the new Deployment mapping, no stale Settings/Values lookups remain, and list values are used directly where Fn::Split was dropped.)

[dnyw4l3n13]

Code review clean - advancing to security review (board moved by the orchestrator: the session reported no findings but did not move it)

[dnyw4l3n13]

Security review clean, advancing to coverage check (diff only regroups existing CloudFormation mapping values; no new permissions, CIDRs or secrets).

[dnyw4l3n13]

Security review clean, advancing to coverage check (board moved by the orchestrator: the session reported no findings but did not move it)

[dnyw4l3n13]

Coverage ratchet skipped (non-code-only: CHANGELOG.md, README.md, cloudformation.json) - advancing to Human Review

[dnyw4l3n13]

AI Review Loop: reviewed d490224

[credfeto]

Super-linter summary

Language	Validation result
CLOUDFORMATION	Pass ✅
JSON	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter