Repository navigation
C/C++: Skip redundant iterator use-use edges. - #23018
Open
aschackmull wants to merge 1 commit into
Open
aschackmull wants to merge 1 commit into
aschackmull wants to merge 1 commit into
Conversation
Contributor
Author
|
Dca is uneventful. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change excluding redundant iterator use-use edges from C/C++ IR data flow.
No open issues 🎉
What changed in this PR
This PR removes redundant iterator use-use edges from C/C++ IR data flow, relying on regular SSA flow to handle those connections and respect modeled flow barriers.
Changes:
- Passes
falseto exclude use-use steps from iterator local flow. - Adds a comment explaining why regular SSA flow already covers these steps.
| File | Description |
|---|---|
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll |
Excludes redundant iterator use-use steps and documents the rationale. |
Review effort: Balanced (auto)
MathiasVP
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.