Skip to content

Type inference: Remove ParenExpr #23025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hvitved wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −18
Open

Type inference: Remove ParenExpr #23025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2322,11 +2322,6 @@ private module Input3 implements InputSig3 {

class AssignExpr extends AssignmentImpl, Rust::AssignmentExpr { }

// Required by the shared type-inference signature; parenthesized expressions are transparent.
abstract class ParenExpr extends Expr {
Expr getExpr() { none() }
}

final class Declaration = DeclarationImpl;

abstract private class DeclarationImpl extends AstNode {
Expand Down
7 changes: 0 additions & 7 deletions shared/typeinference/codeql/typeinference/internal/TypeInference.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2220,11 +2220,6 @@ module Make1<LocationSig Location, InputSig1<Location> Input1> {
/** A simple assignment expression, for example `x = y`. */
class AssignExpr extends Assignment;

/** A parenthesized expression. */
class ParenExpr extends Expr {
Expr getExpr();
}

/**
* A variable, or an entity that behaves like a variable with respect to
* type inference, for example a local variable, `const` item, or `static`
Expand Down Expand Up @@ -2774,8 +2769,6 @@ module Make1<LocationSig Location, InputSig1<Location> Input1> {
n1 = decl.getInitializer() and
n2 = decl.getPattern()
)
or
n1 = n2.(ParenExpr).getExpr()
)
}

Expand Down
6 changes: 0 additions & 6 deletions unified/ql/lib/codeql/unified/internal/typeinference/TypeInference.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,6 @@ module Input3 implements InputSig3 {

class AssignExpr extends Assignment, Unified::AssignExpr { }

class ParenExpr extends Expr {
ParenExpr() { none() }

Expr getExpr() { none() }
}

private newtype TDeclaration =
TAstVariableDeclaration(Unified::VariableDeclaration decl) or
TCallableDeclaration(Unified::Callable c) or
Expand Down
Loading