Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/ql/lib/change-notes/2026-11-05-await-side-effects.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Await expressions are now treated as having side effects. This prevents false positives from the "Statement has no effect" query (`py/ineffectual-statement`) when an awaited task or coroutine's result is discarded.
2 changes: 2 additions & 0 deletions python/ql/lib/semmle/python/Exprs.qll
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,8 @@ class None extends NameConstant {
class Await extends Await_ {
/* syntax: await Expr */
override Expr getASubExpression() { result = this.getValue() }

override predicate hasSideEffects() { any() }
}

/** A formatted string literal expression, such as `f'hello {world!s}'` */
Expand Down
15 changes: 15 additions & 0 deletions python/ql/test/query-tests/Statements/no_effect/await_task.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import asyncio


async def returns_value():
return 42


async def await_task_result():
task = asyncio.create_task(returns_value())
await task


async def await_coroutine_result():
coroutine = returns_value()
await coroutine