Repository navigation
ci: test the SDK on Python 3.12 as well as 3.10 - #193
Merged
Merged
Conversation
The discriminator enum bug only shows on Python 3.11+, and the Test workflow was only exercising the mise.toml pin of 3.10. Co-authored-by: Chris Freeman <chris-freeman-glean@users.noreply.github.com>
steve-calvert-glean
approved these changes
Nov 11, 2026
steve-calvert-glean
left a comment
steve-calvert-glean
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The matrix runs 3.10 and 3.12, the version check fails fast if mise picks the wrong interpreter, and both jobs pass.
chris-freeman-glean
deleted the
cfreeman/python-3-12-test-matrix-4588
branch
November 11, 2026 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enum discriminator bug only fails on Python 3.11 and newer. Test was running 3.10, the version pinned in
mise.toml, so a regression of the 0.17.20 fix would stay green.Test now runs the same suite on 3.10 and 3.12.
MISE_PYTHON_VERSIONoverrides the mise pin per job, and the tool cache key includes that version. Local development stays on 3.10. Generated files are unchanged.Test plan
pytest tests/test_chat_sdk.py::test_chat_sdk_platform_chat_createpassed on this branch (the fixedto_discriminator).to_discriminatorreverted to the pre-0.17.20 body locally and not committed, the same command failed. Pydantic rejected tagPlatformChatJSONSchemaFormatType.JSON_SCHEMA(expectedJSON_SCHEMA).Risk and revert
Workflow only. Reverting this commit returns CI to the 3.10-only run. No package or API change.