Repository navigation
deps: move to Go 1.26 and api-client-go v0.17.3 - #167
Merged
Merged
Conversation
api-client-go v0.17.3 is the first SDK line generated after the platform Search and Chat APIs went GA, and it requires Go 1.26.10. Moving to it keeps the platform-first search and agents commands on the current API models instead of the pre-GA v0.13.4 ones. - go.mod: go 1.26.10, api-client-go v0.13.4 -> v0.17.3 - golang.org/x/oauth2 v0.37.0, x/mod v0.42.0, x/term v0.47.0 (these Dependabot bumps were blocked only by the Go version) - mise.toml, CI matrix label and CONTRIBUTING.md: Go 1.26 - agents run: messages use PlatformMessageInput, the SDK's request type (same JSON shape: role plus text content blocks) - entities read-people dry-run snapshot: the SDK now serializes the new optional fallbackToAuthenticatedIdentity field with its default (false)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI pins api-client-go v0.13.4, which predates the SDK release that marked the platform Search and Chat APIs GA. The next release makes
glean searchandglean agentsplatform-first by default, so it should ship on current SDK models. api-client-go v0.17.3 requires Go 1.26.10, so this PR moves the toolchain too.Changes
go.mod:go 1.26.10, api-client-go v0.13.4 → v0.17.3.mise.toml, the CI matrix label andCONTRIBUTING.md: Go 1.26. CI and release jobs take Go frommise.toml.agents run:messagesusescomponents.PlatformMessageInput, the SDK's request type. The JSON shape is unchanged (rolepluscontenttext blocks).entities read-peopledry-run snapshot: the SDK now serializes the new optionalfallbackToAuthenticatedIdentityfield with its default,false.Verification
go build,go vetandgo test -race ./...pass on Go 1.26.10.golangci-lintv2.11.4 (the CI pin, built with Go 1.26.1) reports 0 issues.--dry-runrequest bodies from amainbuild and this branch forsearch(flags and--json),agents run,agents search,chat,documents retrieveandanswers list. They are identical.entities read-peoplediffers only by the defaultfallbackToAuthenticatedIdentity: false.