Repository navigation
docs: narrow engine#418's root cause further (round 47) - #442
Merged
Merged
Conversation
Instrument the real, currently-served GitHub Support chunk and render the real page end to end: i18next's resolve() returns the caller's own options object without ever calling the real ResourceStore.getResource, disproving round 36's react-i18next/settle-timing theory along the way. Root cause still open; no production code changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.logprobes and rendered the real page end to end (engine.Renderagainst the livesupport.github.com/request/landing, via a customhttp.RoundTrippersubstituting only that one chunk's bytes). For all 58 realt()calls the page makes, i18next's ownresolve()returns the caller's OWN options object as the "resolved" value, without ever calling the realResourceStore.getResource— traced to a specific call site insideresolve()that never fires, for a reason not yet isolated. The most likely engine-level theory (a nested function'svaraccumulator leaking an outer binding) was tested in isolation and ruled out.Test plan
go build ./.../go vet ./...clean (nothing in the engine itself changed)git status --porcelainempty before this commit (all scratch probes, patched chunk copies, and the temporary driver program deleted after use)🤖 Generated with Claude Code