Repository navigation
go 1.27.4 for GO-2026-6859, and the CI pin reads go.mod - #8
Merged
Merged
Conversation
… env var GO-2026-6859, published 2026-11-11, CVE-2026-97054: "HTTP/1 server crash due to MaxBytesReader header race in net/http", standard library, fixed in 1.26.11 and 1.27.4. Read at https://vuln.go.dev/ID/GO-2026-6859.json rather than quoted from notes. The `go` directive is the only one of the three Go pins a CONSUMER reads, and `modfloor --floor 1.27.4` read the directive this module PUBLISHED at v0.3.1 as `go 1.27.3`, reported PUBLISHED: a consumer installing it under GOTOOLCHAIN=local built against an unpatched standard library. ⚠ Reachability is govulncheck's question, not this line's, and this repository is NOT in the fleet's network-facing list. The floor is raised because a consumer is entitled to build against the patched library. ⛔ AND THE CI PIN HAD TO MOVE IN THE SAME CHANGE. The workflow held `GO_VERSION: "1.27.3"` and its only setup-go step read `${{ env.GO_VERSION }}` — a hard-coded pin one indirection away. `setup-go` sets GOTOOLCHAIN=local, so a pin under the directive does not build an older toolchain quietly, it REFUSES with `go.mod requires go >= 1.27.4`. Measured the same day on five of six go-filesystems repositories: every job red at once for a one-line change. ⚠ AND THE INDIRECTION HID IT FROM THE AUDITOR. `gofloor` reports a hard-coded `go-version` as a finding and classifies `${{ … }}` merely as "expression", so this repository read as clean while its pin sat two patch releases behind the floor the fleet was moving to. Three of the five Go repositories in this organisation have that shape — browserproxy (fixed today), engine (current but invisible at the next raise), and this one. Being filed against gofloor separately. The step now reads `go-version-file: go.mod`, so the toolchain is the declared floor by construction. ⚠ Worth recording about the method rather than the change: this clone was FOUR COMMITS STALE (1585 insertions, cmd/webtest and driver/ added), and an edit made before fetching would have produced a pull request reverting all of it. Fetched and fast-forwarded to e5b0f39 before touching anything. actionlint clean, gofmt silent, go build and go test ./... pass, and the only `go-version` text left in the workflow is this change's own explanation. MINOR, not patch: a raised floor is a genuine break for a consumer pinned below it with GOTOOLCHAIN=local — their build stops instead of quietly producing a vulnerable binary. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two halves, both required: the published floor, and the CI pin that would otherwise refuse it.
1.
go 1.27.3→go 1.27.4GO-2026-6859, published 2026-11-11,
CVE-2026-97054, "HTTP/1 server crash due to MaxBytesReader header race in net/http", standard library, fixed in 1.26.11 and 1.27.4 — read at vuln.go.dev rather than quoted from notes.The
godirective is the only one of the three Go pins a consumer reads: the CI pin builds our artefacts, the toolchain stamped in a binary describes one executable, and this line is whatgo installhonours underGOTOOLCHAIN=local.Measured:
modfloor --floor 1.27.4read the directive this module published at v0.3.1 asgo 1.27.3, and reported itPUBLISHED— so a consumer installing it that way built against an unpatched standard library.⚠ Reachability is govulncheck's question, not this line's. And unlike the eight modules raised earlier today, this repository is not in the fleet's network-facing list — the floor is raised because a consumer is entitled to build against the patched library, not on an exposure claim.
2. ⛔ The pin was hidden behind an env var
The workflow held
GO_VERSION: "1.27.3"and its onlysetup-gostep read${{ env.GO_VERSION }}— a hard-coded pin one indirection away.setup-gosetsGOTOOLCHAIN=local, so a pin under the directive does not build an older toolchain quietly; it refuses:Measured the same day on five of six go-filesystems repositories: every job red at once for a one-line change to
go.mod. So both move together here.⚠ And the indirection hid it from the auditor.
gofloorreports a hard-codedgo-versionas a finding and classifies${{ … }}merely as "expression", so this repository read as clean while its pin sat two patch releases behind the floor the fleet was moving to. Three of the five Go repositories in this organisation have that shape —browserproxy(fixed today),engine(current, invisible at the next raise), and this one. Being filed againstgofloorseparately.The step now reads
go-version-file: go.mod, so the toolchain is the declared floor by construction and the next raise needs no edit here.⚠ One note about method, not about this change
This clone was four commits stale — 1585 insertions,
cmd/webtest/anddriver/added — and an edit made before fetching would have produced a pull request reverting all of it. Fetched and fast-forwarded toe5b0f39before touching anything.Measured
actionlintclean,gofmt -l .silent,go build ./...andgo test ./...pass. The onlygo-versiontext left in the workflow is this change's own explanation.Release level: MINOR
A raised floor genuinely breaks a consumer pinned below it with
GOTOOLCHAIN=local: their build stops rather than quietly producing a vulnerable binary. The release is the fix, not the merge — a consumer reads the publishedgo.mod.🤖 Generated with Claude Code