Repository navigation
Conversation
`Fdt::new` validates only the strings that a property's `nameoff` points to, so the `dt_strings` block of an accepted tree may contain bytes that are not a null-terminated UTF-8 string. `find_existing_string` walked the whole block and expected every string to be valid, which made `FdtNodeMut::add_property` panic whenever the new name was not found before such bytes. Compare raw bytes instead: split the block at each null terminator, compare every terminated piece with the name, and skip a trailing piece without a terminator. A piece that is not a valid string can never equal a `&str`, so it is passed over and the name is appended as before. Fixes google#109 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 26 26
Lines 3428 3428
=======================================
Hits 3209 3209
Misses 219 219 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_existing_stringnow compares raw bytes, as libfdt'sfdt_find_string_does: it splits the strings block at each null terminator, compares each terminated piece with the name, and skips a trailing piece with no terminator. Bytes that are not a valid string can then never match and never panic.The new test covers an unterminated byte, a terminated byte that is not UTF-8, and a name that already exists before the invalid bytes, which is reused.
Fixes #109