Repository navigation
Fix eDO client distant-object cache eviction and lookup races. - #307
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1018821130
branch
from
November 13, 2026 19:49
8ace8d2 to
adf5be1
Compare
Make `+cachedEDOFromObjectUpdateIfNeeded:` look up, update, and return the cached `EDOObject` atomically inside a single queue dispatch, releasing any displaced entry after the dispatch returns. When the incoming object is already the cached entry, return it without marking it `local = YES` (fixing a host-object leak on dealloc). Update `-[EDOObject dealloc]` to remove the cached reference only if the cache still holds that instance. PiperOrigin-RevId: 1021218831
copybara-service
Bot
force-pushed
the
test_1018821130
branch
from
November 13, 2026 20:04
adf5be1 to
cbc0842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix eDO client distant-object cache eviction and lookup races.
Make
+cachedEDOFromObjectUpdateIfNeeded:look up, update, and return thecached
EDOObjectatomically inside a single queue dispatch, releasing anydisplaced entry after the dispatch returns. When the incoming object is
already the cached entry, return it without marking it
local = YES(fixinga host-object leak on dealloc). Update
-[EDOObject dealloc]to remove thecached reference only if the cache still holds that instance.