Repository navigation
Bound nested IFields by their parent when reading. - #1079
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
ReadVisitor checked nested IFields against the end of the span rather than the end of their parent. When the parent isn't last in the span, e.g. in a vector of IFields, new code reading old data or a nested field running past its parent hit the end_ assert instead of treating the field as missing or returning pos == 0. Follow-up to #1050. PiperOrigin-RevId: 1016446589
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound nested IFields by their parent when reading.
ReadVisitor checked nested IFields against the end of the span rather than the
end of their parent. When the parent isn't last in the span, e.g. in a vector
of IFields, new code reading old data or a nested field running past its parent
hit the end_ assert instead of treating the field as missing or returning
pos == 0. Follow-up to #1050.