Repository navigation
Fix KVCache::Copy() for tiled KV caches. - #1080
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1016446564
branch
3 times, most recently
from
November 9, 2026 19:49
4607664 to
700d3e3
Compare
Copy() never allocated the compact local/global tile storage, so copying a cache created with any tiled attention_impl aborted in CopyMat(). Allocate and copy that storage, and point the copy's kv_head_ptrs at it instead of leaving them empty. PiperOrigin-RevId: 1017521437
copybara-service
Bot
force-pushed
the
test_1016446564
branch
from
November 9, 2026 19:53
700d3e3 to
39c7a93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KVCache::Copy() for tiled KV caches.
Copy() never allocated the compact local/global tile storage, so copying a
cache created with any tiled attention_impl aborted in CopyMat(). Allocate and
copy that storage, and point the copy's kv_head_ptrs at it instead of leaving
them empty.