Skip to content

Add max-line-length configuration support to the IntelliJ plugin - #1471

Open
fredyw wants to merge 2 commits into
google:masterfrom
fredyw:add-max-line-length-idea-plugin
Open

Add max-line-length configuration support to the IntelliJ plugin#1471
fredyw wants to merge 2 commits into
google:masterfrom
fredyw:add-max-line-length-idea-plugin

Conversation

@fredyw

@fredyw fredyw commented Oct 3, 2026

Copy link
Copy Markdown
  • Update idea_plugin to depend on google-java-format 1.37.0.
  • Add max line length setting to GoogleJavaFormatSettings and UI.
  • Preserve custom maxLineLength across Google and AOSP style selection.
  • Add tests for settings persistence and formatting service.

@fredyw
Add max-line-length configuration support to the IntelliJ plugin.
cc66035 
- Update idea_plugin to depend on google-java-format 1.37.0.
- Add max line length setting to GoogleJavaFormatSettings and UI.
- Preserve custom maxLineLength across Google and AOSP style selection.
- Add tests for settings persistence and formatting service.
@google-cla

google-cla Bot commented Oct 3, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

cushon
cushon requested changes Nov 1, 2026
View reviewed changes

@cushon cushon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredyw it looks like you are not currently covered under a CLA: #1471 (comment)

@fredyw

fredyw commented Nov 1, 2026

Copy link
Copy Markdown
Author

@fredyw it looks like you are not currently covered under a CLA: #1471 (comment)

I requested one after sending a PR. The most up-to-date status is in the checks section.

image

@fredyw

fredyw commented Nov 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Is there anything that I can do to fix the failing http://cl/1011558571? I'm not able to see what's in it.

@cushon

cushon commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

Is there anything that I can do to fix the failing http://cl/1011558571? I'm not able to see what's in it.

There's a failing internal presubmit because GoogleJavaFormatSettingsTest.java doesn't have a license header comment, I can take care of adding that and getting this merged.

Thanks for the PR!

@cushon cushon mentioned this pull request Nov 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cushon cushon cushon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fredyw @cushon