Repository navigation
Make SnippetFormatter whitespace-only. - #1517
Merged
Merged
Conversation
`SnippetFormatter` converts the formatted snippet back into replacements under the assumption that only whitespace changed, and throws `IllegalArgumentException` otherwise. Since 2.0.0 enabled cleanups by default, snippets that contain e.g. `(x) -> x`, `@Foo()`, or redundant semicolons hit that check, and the Eclipse plugin (which catches the exception) silently skips formatting. Snippets that needed modifier reordering already failed the same way. Always disable cleanups and modifier reordering in `SnippetFormatter`, since it can only apply whitespace changes. PiperOrigin-RevId: 1011550252
copybara-service
Bot
force-pushed
the
test_1010462527
branch
from
November 1, 2026 11:14
c93d6d3 to
26b9db1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
SnippetFormatterwhitespace-only.SnippetFormatterconverts the formatted snippet back into replacements under the assumption that only whitespace changed, and throwsIllegalArgumentExceptionotherwise. Since 2.0.0 enabled cleanups by default, snippets that contain e.g.(x) -> x,@Foo(), or redundant semicolons hit that check, and the Eclipse plugin (which catches the exception) silently skips formatting. Snippets that needed modifier reordering already failed the same way.Always disable cleanups and modifier reordering in
SnippetFormatter, since it can only apply whitespace changes.