Repository navigation
Parse nested expressions in flag defaults - #146
Open
vinsymoyya wants to merge 1 commit into
Open
vinsymoyya wants to merge 1 commit into
vinsymoyya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested expressions in flag defaults currently disappear from generated help, and parentheses inside string literals can truncate the displayed default. For example,
get(split(s:foobar), 0, '')produces no Default line.Keep the existing flag-name recognition and scan the default expression with balanced parentheses and Vim single/double-quoted string handling. Stop at the flag call's closing parenthesis, preserving arbitrary nesting and escaped quotes. Incomplete expressions continue to omit the default rather than emitting a truncated value.
Fixes #122.
Validation: six nested/quoted expression cases fail against upstream
b2b9273. After the fix,python -m pytest -q --doctest-modulespasses all 14 tests/doctest modules and 4 subtests. Coverage includes the report's line-continuation form and an incomplete expression.git diff --checkpasses. The source checkout emits the existing setuptools-scm version warning.