Skip to content

Resolve overload links through the primary definition - #147

Open
vinsymoyya wants to merge 1 commit into
google:mainfrom
vinsymoyya:fix/overload-link-targets
Open

vinsymoyya wants to merge 1 commit into
google:mainfrom
vinsymoyya:fix/overload-link-targets

Conversation

@vinsymoyya

Copy link
Copy Markdown

Linking to an overloaded function or command currently raises Found multiple ...s named ..., even though the extra blocks are usage variants of a single definition. This prevents help generation when an inline directive references that definition.

Exclude secondary usage blocks, which deliberately have no tag, from tag lookup candidates. Resolve the primary definition's tag while retaining the existing error for genuinely duplicate definitions. Regression tests exercise function links, both command-link spellings, and real duplicates through parsed documentation blocks.

Addresses the link-resolution bug in #38. The separate signature-validation behavior discussed in that issue is outside this patch.

Validation: function and command regressions fail on upstream b2b9273 with the reported duplicate-definition exception. python -m pytest -q --doctest-modules passes all 12 tests/doctest modules with the fix; git diff --check passes. The source checkout emits the existing setuptools-scm version warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant