Skip to content

fix(toolbar): align settings control geometry - #129

Merged
kbuffardi merged 1 commit into
mainfrom
fix/settings-toolbar-geometry
Nov 4, 2026
Merged

kbuffardi merged 1 commit into
mainfrom
fix/settings-toolbar-geometry

Conversation

@kbuffardi

Copy link
Copy Markdown
Owner

Summary

  • Replace the Settings Unicode gear with the existing Monaco codicon-gear.
  • Remove the Unicode-specific size rule that made the Settings control taller.
  • Add source and Chrome smoke regression checks for matching toolbar glyph sizes
    and bounds.

Validation

  • Passed: npm run lint
  • Passed: npm run build
  • Passed: npm run test:e2e (239 tests)
  • Chrome smoke reached and passed the new Settings assertions, then failed on an
    unrelated existing check: vs terminal selection foreground is incorrect.

Closes #128

Use the shared Codicon gear so Settings matches neighboring toolbar controls.\n\nRefs #128
@kbuffardi
kbuffardi merged commit a696745 into main Nov 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(toolbar): align settings control geometry

1 participant