Repository navigation
Conversation
beekld
marked this pull request as ready for review
November 6, 2026 03:27
beekld
force-pushed
the
bklimt/SDK-3402/monotonic-deadlines
branch
2 times, most recently
from
November 6, 2026 17:37
7a1fa34 to
5198a56
Compare
tanderson-ld
approved these changes
Nov 6, 2026
beekld
force-pushed
the
bklimt/SDK-3402/monotonic-deadlines
branch
7 times, most recently
from
November 11, 2026 01:29
3812f38 to
1d4190d
Compare
beekld
force-pushed
the
bklimt/SDK-3402/monotonic-deadlines
branch
from
November 11, 2026 01:44
1d4190d to
d8cd1e1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FDv2 synchronizer loop measured its deadlines against the wall clock. When the system clock stepped backwards, every pending deadline was delayed by the size of the step. If every synchronizer was parked for 5 minutes and the clock stepped back an hour, no synchronizer ran for 65 minutes.
These deadlines now use
MonotonicTime, a small value class overSystem.nanoTime(), so changes to the system clock don't move them.Stacked on #252.
Note
Overview
FDv2 synchronizer orchestration previously scheduled recovery, fallback, park/unpark, and FDv1 fallback TTL deadlines using wall-clock
Instant. A backward system clock step could postpone those deadlines and keep sources parked or on FDv1 longer than intended.This PR introduces
MonotonicTime(backed bySystem.nanoTime()) and wires it throughFDv2DataSource,SourceManager, andSynchronizerFactoryWithStatefor all internal wait/deadline logic (awaitUntil,earliest, parking, fallback end times).MonotonicTimeTestcovers comparison and duration math across nanosecond counter overflow.Reviewed by Cursor Bugbot for commit d8cd1e1. Bugbot is set up for automated code reviews on this repo. Configure here.