Repository navigation
fix(sync): keep descriptor metadata out of the remote manifest - #1027
Merged
Merged
Conversation
The sync manifest API records the fingerprint and the version of each entry and rejects fingerprintSchema, referenceDigest, and adapterBehavior with "additional properties not allowed". The client no longer sends them in an upsert or reads them from a response. The sync.lock file keeps that metadata, so a change to it alone sends nothing to LaunchDarkly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ctawiah
marked this pull request as ready for review
November 10, 2026 19:52
ctawiah
requested review from
davidbrackbill and
nkester-ld
and removed request for
a team
November 10, 2026 19:52
nkester-ld
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A push of a linked variation ends with a patch of the remote sync manifest, and LaunchDarkly rejected it with
/properties/upserts/items/additionalProperties additional properties 'fingerprintSchema', 'referenceDigest', 'adapterBehavior' not allowed. The variation was written, the baseline was not, so the next plan saw the push again. The remote manifest records the fingerprint and the version of each entry, and nothing else.What changes
SyncManifestResourceandSyncManifestUpsertcarry the kind, the lookup key, the fingerprint, and the version only.sync.lockfile keeps the descriptor metadata, as before. The lock travels with the repository, so every working copy reads it from there.Design notes
Review focus
Verification
go test ./...golangci-lint run ./...TestStoreUpdatesWithRemoteVersionsasserts the upsert without the metadata, andTestStoreSendsNothingForADescriptorMetadataChangecovers a metadata-only change.Related changes
🤖 Generated with Claude Code
Note
Overview
Stops sending descriptor metadata (
fingerprintSchema,referenceDigest,adapterBehavior) in remote sync manifest API payloads, which LaunchDarkly rejects as additional properties and was blocking baseline updates after linked variation pushes.SyncManifestResourceandSyncManifestUpsertnow only expose kind, lookup key, fingerprint, and version. The manifest store loads and patches with that same subset, andsameManifestContentcompares fingerprints only, so updates that change lock-only descriptor metadata without a fingerprint change do not emit a patch. Descriptor metadata remains on local manifest/sync.lockresources as before.Reviewed by Cursor Bugbot for commit a7dcd10. Bugbot is set up for automated code reviews on this repo. Configure here.