Repository navigation
Conversation
The polling, streaming and FDv1 fallback builders now take their base URI, socket factory, read timeout and connect timeout from Config when the builder does not set them. Config gets base_uri and stream_uri back as the default URIs for the polling and streaming data sources. A value set on a builder overrides the Config value. Before this change, the builders ignored the top-level read_timeout, connect_timeout and socket_factory, and a Relay Proxy user had to rebuild the default data system with DataSystem.custom to set the URIs. A v8 configuration that sets base_uri, stream_uri and events_uri for a Relay Proxy instance now works without change.
… mk/SDK-3538/http-options
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The polling, streaming and FDv1 fallback builders now take their base
URI, socket factory, read timeout and connect timeout from Config when
the builder does not set them. Config gets base_uri and stream_uri back
as the default URIs for the polling and streaming data sources. A value
set on a builder overrides the Config value.
Before this change, the builders ignored the top-level read_timeout,
connect_timeout and socket_factory, and a Relay Proxy user had to
rebuild the default data system with DataSystem.custom to set the URIs.
A v8 configuration that sets base_uri, stream_uri and events_uri for a
Relay Proxy instance now works without change.
Note
Overview
Reintroduces
base_uriandstream_urionLaunchDarkly::Config(with defaults and trailing-slash normalization) so Relay Proxy and similar setups can set polling, streaming, and events endpoints at the top level again—without rebuilding the data system viaDataSystem.custom.Polling, FDv1 polling, and streaming builders now build
HttpConfigOptionsfrom the SDK config when they do not set a value: polling usesconfig.base_uri, streaming usesconfig.stream_uri, and all three inheritsocket_factory,read_timeout, andconnect_timeoutfromConfig. Builder-level settings still override the config.Docs add a Relay Proxy example; specs cover config defaults and the config vs builder precedence for HTTP options.
Reviewed by Cursor Bugbot for commit 3b16100. Bugbot is set up for automated code reviews on this repo. Configure here.