Repository navigation
add missing <climits> include - #46
Open
peppergrayxyz wants to merge 1 commit into
Open
peppergrayxyz wants to merge 1 commit into
peppergrayxyz wants to merge 1 commit into
Conversation
building on gentoo/musl fails with error:
```
FAILED: [code=1] src/CMakeFiles/linuxdeploy-plugin-appimage.dir/main.cpp.o
/docker-ramdisk/linuxdeploy-build-S2cK5w/linuxdeploy-plugin-appimage/src/main.cpp: In function 'std::string findAppimagetool()':
/docker-ramdisk/linuxdeploy-build-S2cK5w/linuxdeploy-plugin-appimage/src/main.cpp:21:27: error: 'PATH_MAX' was not declared in this scope
21 | std::vector<char> buf(PATH_MAX, '\0');
| ^~~~~~~~
```
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 10, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 11, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 11, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
added a commit
to peppergrayxyz/linuxdeploy
that referenced
this pull request
Nov 11, 2026
The musl builds need fixes which are not merged yet: - linuxdeploy/linuxdeploy-plugin-appimage#45 - linuxdeploy/linuxdeploy-plugin-appimage#46 - linuxdeploy/linuxdeploy-desktopfile#11 - linuxdeploy/cmake-scripts#1 Carry them in ci/upstream-patches, and apply them in build.sh and the workflow. Revert this commit once all of them are merged. Signed-off-by: Pepper Gray <hello@peppergray.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
building on gentoo/musl fails with error: