Repository navigation
Trash: split purge into mark and remove steps - #57
Merged
Merged
Conversation
markPurged and removeUnheld do the two halves of Delete forever, so other callers can mark messages purged for several addresses before removing what nobody holds. No change in behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor only, no change in behaviour:
purgenow calls two steps,markPurged(ctx, identity, ids, threadTop, now): marks ids deleted for good for one address and returns the quota releases;removeUnheld(ctx, ids): removes from the host each id nobody here holds, deepest first, and returns the files to delete after commit.This lets a caller mark messages purged for several addresses (an owner and its sub-addresses hold each other's messages) before removing anything. It's needed for deleting inactive accounts on fmsg.ai.
Tests:
go test ./...withFMSG_TEST_DATABASE_URL(Postgres 17), all pass, including the trash and purge integration tests.🤖 Generated with Claude Code