Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
decodeArrayStream()reads the outer array header outside its incomplete-data handling block. An array16 or array32 length field split across stream chunks therefore raises aRangeErrorbefore the remaining bytes can arrive.This also affects canonical encoder output: encode an array of 16 objects, yield its first byte in one chunk, and yield the rest in the next chunk. Decoding the same bytes in one chunk succeeds.
Change
Tests cover every split inside array16/array32 headers, byte-at-a-time input with empty chunks and non-zero view offsets, nested values, and truncated headers. No other stream validation behavior is changed intentionally.
Validation
AI assistance
This patch, tests, and draft were prepared with OpenAI Codex assistance and independently reviewed by another AI agent. The test results above are from executed checks; this does not claim a human code review.