Skip to content

Adding TDR Measurement Example in NI-Digital - #2255

Draft
karthikeswari-veerakumar wants to merge 6 commits into
ni:masterfrom
NI-velmurugan:users/karthi/add-nidigital-tdr-measurement-example
Draft

karthikeswari-veerakumar wants to merge 6 commits into
ni:masterfrom
NI-velmurugan:users/karthi/add-nidigital-tdr-measurement-example

Conversation

@karthikeswari-veerakumar

@karthikeswari-veerakumar karthikeswari-veerakumar commented Nov 3, 2026 •

Copy link
Copy Markdown
  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • [] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds tdr_measurement.py, an example based on the LabVIEW "TDR Measurement" VI.
  • Demonstrates how to use the NI-Digital Pattern Driver API to create an instrument session and use Time-Domain Reflectometry (TDR) to measure propagation delays through cables, connectors, and load boards on each channel in the channel list.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Validation completed with the simulative instrument 6570

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@codecov-commenter

codecov-commenter commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.36%. Comparing base (9b70885) to head (25b8965).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2255      +/-   ##
==========================================
- Coverage   88.12%   87.36%   -0.76%     
==========================================
  Files          88       86       -2     
  Lines       22830    22535     -295     
==========================================
- Hits        20118    19688     -430     
- Misses       2712     2847     +135     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.36% <ø> (ø)
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 73.04% <ø> (-9.67%) ⬇️
nirfsaunittests 63.37% <ø> (ø)
nirfsgsystemtests 81.22% <ø> (ø)
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Remove whitespace from the project filename so Make can resolve example dependencies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@karthikeswari-veerakumar
karthikeswari-veerakumar marked this pull request as draft November 3, 2026 11:31
@karthikeswari-veerakumar karthikeswari-veerakumar changed the title Users/karthi/add nidigital tdr measurement example Adding TDR Measurement Example in NI-Digital Nov 3, 2026
@divakar-selvam07

Copy link
Copy Markdown
Contributor

Hardware validation could not be completed because this measurement requires two identical instruments, while the available setup consists of a PXIe-6570 and a PXIe-6571.
Refer: resource_name

@Avinash2Suresh Avinash2Suresh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with Suggestions

Comment thread CHANGELOG.md Resolved
Updated comments for clarity and improved help text in argument parser.
Co-authored-by: Avi <147520106+Avinash2Suresh@users.noreply.github.com>
@karthikeswari-veerakumar

Copy link
Copy Markdown
Author

@jarnoldNI, the PR is ready for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants