Repository navigation
ci: run unit tests once per pull request push - #107
Merged
Merged
Conversation
Branch pushes ran the unit tests twice: once for the push and once for the pull request. Keep push runs for main only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ci.ymlruns onpushto every branch and onpull_requesttomain, so each push to a PR branch runs the unit tests twice. #106, for example, got apushrun at 20:36:57 and apull_requestrun at 20:37:10. Since mid-October that's 60 push runs and 40 pull request runs, about 7.5 runner minutes each.Change
Trigger
pushonly formain. PRs still get theirpull_requestrun, andmainstill gets a run after each merge.mainhas no required status checks, so nothing depended on the branchpushruns. Branches pushed without a PR no longer run CI.