Repository navigation
DOC: Add "NumPy for MATLAB users" migration guide - #314
InessaPawson wants to merge 3 commits into
Conversation
MAINT: Remove local virtual environment from PR
|
@bsipocz I pushed 6f0ca89 to make the Python examples executable and removed the page from Tested locally with |
|
@bsipocz While porting I noticed several issues in the guide. I’m keeping this PR as a straight migration, will address those in a follow-up. |
melissawm
left a comment
There was a problem hiding this comment.
Thanks @InessaPawson ! Left some optional comments 😄
|
|
||
| ### Linear algebra equivalents | ||
|
|
||
| ````{list-table} |
There was a problem hiding this comment.
Would it be too difficult to test making these tables scrollable? They are ok as they are, but the long paragraphs may be more readable if they have a bit more space on the page. Not sure which solution would be best but I'd love to be able to compare if it's not too much trouble!
| - `:)` Element-wise multiplication is easy: `A*B`. | ||
| - `:(` You have to remember that matrix multiplication has its own |
There was a problem hiding this comment.
I think these emoticons don't translate as well anymore and people are more used to emojis, can we replace them?
rossbar
left a comment
There was a problem hiding this comment.
+1 from me - AIUI this is essentially just copying over the numpy-for-matlab-users article from the numpy user guide over here.
I also generally agree with @bsipocz that it'd be worthwhile to actually convert the code snippets into something that is actually executable1, but that can be done in follow-up. It makes sense to me to have a single PR that leaves the content as-is and just deals with the move/translation between sites.
Thanks @InessaPawson
Footnotes
-
the very first column is a good example:
infois a numpy fn, so should benp.info, whereashelpis a Python fn. ↩
|
One final thought - I think adding the "Migration Guide" subheading is fine, but I also wouldn't be opposed to making this a top-level document (i.e. one that shows up on the nav bar). Something else that could be worried about in follow-up! |
Moves the “NumPy for MATLAB users” page from the NumPy user guide into numpy/numpy-tutorials.
Part of the work on addressing numpy/numpy#33233.
A follow-up PR in numpy/numpy will replace the original page with a redirect stub.