Repository navigation
Conversation
lpyu001
requested review from
emmatyping,
freakboy3742 and
markshannon
as code owners
October 29, 2026 15:31
lpyu001
requested review from
AA-Turner,
corona10,
erlend-aasland and
itamaro
as code owners
October 29, 2026 15:31
Contributor
Author
|
cc @hoodmane |
Contributor
|
Looks good to me. |
hoodmane
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten 6.0.1 deprecated
-sUSE_PTHREADSand-sMEMORY64in favor of the standard-pthreadand-m64flags (emscripten-core/emscripten#27025). With the currently pinned Emscripten 6.0.10, both emit a-Wdeprecatedwarning at link time:This PR switches
configure.acto the standard flags:--enable-wasm-pthreads:-sUSE_PTHREADS→-pthreadinLDFLAGS_NODIST. The existing-pthreadinCFLAGS_NODISTis not passed to the link step, so the linker flag is still needed.wasm64-*-emscripten:-sMEMORY64=1→-m64inCFLAGSandLDFLAGS.Platforms/emscripten/README.mdis updated to match.I've also removed the Emscripten-specific
NDOTDOTS = 48workaround fromtest_glob_dotdotinLib/test/test_pathlib/test_pathlib.py. Its comment says it can be removed once emscripten-core/emscripten#24591 is merged. That PR (don't return ELOOP on a path with many..components) was merged in June 2025 and should be in 4.0.11 and later, well below the pinned 6.0.10. The test now usesNDOTDOTS = 50on all platforms.pthread_getattr_npworkaround inceval.c#160873