Repository navigation
Conversation
…n Windows The stable ABI forwarder DLLs are linked with /NOENTRY, so nothing pulls in the CRT. With AddressSanitizer enabled, the linker adds the ASan runtime thunk library, which needs the CRT, and the link fails with unresolved symbols. Keep the default CRT entry point for these DLLs when building with ASan.
|
All commit authors signed the Contributor License Agreement. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-150467.
Root cause
python3.dll and python3t.dll only contain
/EXPORTforwarders and are linked with/NOENTRY, so the CRT is never pulled in. With ASan enabled, the linker addsclang_rt.asan_dynamic_runtime_thunk, which needs the CRT (_initterm,abort,__vcrt_*,__acrt_*), so the link fails with LNK2001.python3.dll fails the same way before GH-149218. That change made the problem visible by adding a second forwarder that always gets built.
Fix
pyproject.propssetsPyUsingAsanwhen ASan is enabled throughEnableASAN=true,/fsanitize=addressin_CL_, or/InferASanLibsin_LINK_.python3dll.vcxprojandpython3tdll.vcxprojonly setNoEntryPointwhenPyUsingAsanisn't set, so ASan builds use the default CRT entry point.Non-ASan builds are unchanged: both DLLs still have no entry point and no imports.
Testing
x64 Release, VS 2026 (MSVC 14.51), ASan enabled with the
_CL_/_LINK_settings from the issue:build.bat -e --no-tkinter -p x64 -M -r: failed before, links now.--disable-gil: failed before, links now.dumpbinshows the forwarders unchanged.test_syspasses on all four builds, andtest_capipasses on the free-threaded builds.