Repository navigation
Fix crash on TypeVar with a Callable bound or default referring to itself - #22341
Closed
waw666waw666 wants to merge 1 commit into
Closed
waw666waw666 wants to merge 1 commit into
waw666waw666 wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16940
T = TypeVar("T", bound=Callable[..., "T"])crashes mypy with infinite recursion (a segfault when compiled). Unlike e.g.bound=list["T"], which is reported as a cyclic definition,Callablebinds the free type variableTitself, so after the second semantic analysis pass the stored bound isdef [T <: ...] (...) -> T. Re-analysing that bound on the next pass re-bindsTfrom its ownTypeVarExpr, whose bound is that same callable, andanal_var_def()never terminates. The same happens withdefault=Callable[..., "T"].This PR makes
process_typevar_declaration()detect a bound or default that refers to the type variable being defined, and reports the sameCannot resolve name "T" (possible cyclic definition)error used for the non-Callablecase, replacing the bound/default withAny.Added test cases for both the bound and the default; both crash on master and pass with this change. Bounds that use a different type variable inside a
Callable(e.g.bound=Callable[[S], S]) are unaffected.