Repository navigation
http: send a constant zero as the TriggerEvent detail - #121
Merged
Merged
Conversation
TriggerEvent("count", 0) selected the overload with only a timing,
because a constant zero converts to any enum. The detail was lost, and
the browser received {"count":{}}. The same applied to 0L, 0.0, and 0m.
Add a generic overload next to the object one: an exact match on T beats
the enum conversion. It passes the detail on as object, so the JSON
still follows the runtime type; serializing by T would drop the
properties of a derived type behind a base-typed variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TriggerEvent("count", 0)selected the overload with only a timing, because a constant zero converts to any enum. The detail was lost, and the browser received{"count":{}}. The same applied to0L,0.0, and0m. Variables were not affected.This PR adds
TriggerEvent<T>(string, T, HtmxTriggerTiming)next to the object overload.The object overload stays, so
TriggerEvent("x", null)still compiles and compiled code keeps working.