Repository navigation
config: make the version configuration constructors internal - #128
Merged
Merged
Conversation
HtmxV1Config, HtmxV2Config, and HtmxV4Config had public constructors, but nothing accepts an instance created by hand: HtmxToolkitOptions creates the configuration and passes it to the UseHtmx* delegates. Making a constructor public later is not a breaking change, while the reverse is, so keep them internal, as HtmxResponse already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HtmxV1Config,HtmxV2Config, andHtmxV4Confighad public constructors, but nothing accepts an instance created by hand:HtmxToolkitOptionscreates the configuration and passes it to theUseHtmx*delegates.