Repository navigation
config: require selecting the HTMX version - #132
Merged
Merged
Conversation
HtmxToolkit selected HTMX 2.x when the application chose no version. It cannot detect the script that the browser loads, so an application on HTMX 1.9.x or 4.x silently got markup and response headers for the wrong version. Moving the default to HTMX 4.x later would break existing applications just as silently. Make the AddHtmxToolkit delegate required and fail at startup if no version is selected. Without AddHtmxToolkit, nothing can be validated at startup, so HtmxConfig and TargetVersion throw on first use. This also removes the HTMX 2.x fallback for response events and the side effect of selecting a version by reading HtmxConfig.
Select the version in every registration example and remove the statements about the HTMX 2.x default. Describe the startup and runtime errors in the version guide, the migration guide, and troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HtmxToolkit selected HTMX 2.x when the application chose no version.
It cannot detect the script that the browser loads, so an application on HTMX 1.9.x or 4.x silently got markup
and response headers for the wrong version. Moving the default to HTMX 4.x later would break existing applications just as silently.
Make the
AddHtmxToolkitdelegate required and fail at startup if no version is selected.Without
AddHtmxToolkit, nothing can be validated at startup, soHtmxConfigandTargetVersionthrow on first use.This also removes the HTMX 2.x fallback for response events and the side effect of selecting a version by reading
HtmxConfig.