Repository navigation
otamaker: Reject bad payload names, reproducible builds - #227
Merged
Merged
Conversation
1. Demand that payload names are simple filenames, no more than 100 characters long and with no path elements such as slashes. 2. If the SOURCE_DATE_EPOCH environment variable is set, use that as the timestamp on artefact tar achive members so that the whole file has a consistent SHA256 hash between builds if the content does not change. Manifest hashes are already consistent. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Prior to this change, both legacy and manifest artefacts were created with hashes in <output>.sha256sum. This would be a clean end point, but is likely to be confusing to users in the short term. Instead, always write manifest hashes to <output>.manifest.sha256sum, even when that is the only hash being written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demand that payload names are simple filenames, no more than 100 characters long and with no path elements such as slashes.
If the SOURCE_DATE_EPOCH environment variable is set, use that as the timestamp on artefact tar achive members so that the whole file has a consistent SHA256 hash between builds if the content does not change. Manifest hashes are already consistent.