Skip to content

Say a GitHub token works only in the desktop app - #13

Merged
dvorakj31 merged 1 commit into
masterfrom
fix/web-token-wording
Oct 26, 2026
Merged

dvorakj31 merged 1 commit into
masterfrom
fix/web-token-wording

Conversation

@dvorakj31

Copy link
Copy Markdown
Contributor

What changes, and for whom

For people who use the plugin in the RIM web app: the panel's footer and the plugin's description now say that a GitHub token raises the rate limit in the RIM desktop app.

Until now they told every user to add a token in the plugin's settings. The web app keeps no secret settings, so on the web that pointed to a setting nobody can keep. The plugin can't tell which app it runs in (the SDK exposes no such flag), so both apps now get the same wording, and it names the desktop app.

What it does not do

  • It adds no runtime check for which app the plugin runs in. That would need an SDK and protocol change.
  • It changes no behaviour. On the web, the plugin keeps working with GitHub's unauthenticated limit.
  • It doesn't bump the version. That happens at release.

How it was tested

  • npm run typecheck: tsc printed nothing, exit 0
  • npm run lint: eslint . printed nothing, exit 0
  • npm run format:check: "All matched files use Prettier code style!"
  • npm test: 3 test files passed, 35 tests passed. Two of them are new: the footer text and the manifest description.
  • npm run build and npm run check: main.mjs came out byte-identical (no src/ change); "chat.rim.github-prs: main.mjs and panels/ match a fresh build"
  • CHANGELOG.md has a line under Unreleased → Fixed

Changelog

The panel's footer and the plugin's description say a GitHub token works only in the RIM desktop app, instead of pointing web users to a setting the web app cannot keep.

The panel footer and the manifest description told every user to add a
GitHub token in the plugin's settings, but the web app keeps no secret
settings, so web users were pointed to a setting they cannot keep. The
plugin cannot tell which host it runs in, so both now use one wording
that names the RIM desktop app.
@dvorakj31
dvorakj31 merged commit 884f089 into master Oct 26, 2026
1 check passed
@dvorakj31
dvorakj31 deleted the fix/web-token-wording branch October 26, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant