Repository navigation
Say a GitHub token works only in the desktop app - #13
Merged
Merged
Conversation
The panel footer and the manifest description told every user to add a GitHub token in the plugin's settings, but the web app keeps no secret settings, so web users were pointed to a setting they cannot keep. The plugin cannot tell which host it runs in, so both now use one wording that names the RIM desktop app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes, and for whom
For people who use the plugin in the RIM web app: the panel's footer and the plugin's description now say that a GitHub token raises the rate limit in the RIM desktop app.
Until now they told every user to add a token in the plugin's settings. The web app keeps no secret settings, so on the web that pointed to a setting nobody can keep. The plugin can't tell which app it runs in (the SDK exposes no such flag), so both apps now get the same wording, and it names the desktop app.
What it does not do
How it was tested
npm run typecheck:tscprinted nothing, exit 0npm run lint:eslint .printed nothing, exit 0npm run format:check: "All matched files use Prettier code style!"npm test: 3 test files passed, 35 tests passed. Two of them are new: the footer text and the manifest description.npm run buildandnpm run check:main.mjscame out byte-identical (nosrc/change); "chat.rim.github-prs: main.mjs and panels/ match a fresh build"CHANGELOG.mdhas a line underUnreleased→ FixedChangelog