Repository navigation
The floor rules count the time each beat covered, up to one second (#1613) - #2578
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dungeon's floor rules now count the time each beat actually covered, up to one second, instead of taking every beat as 0.25 s. A slow frame no longer slows them, and a long stall costs at most one second of a rule's effect (#1613).
What changed
game/Source/Cataclysm/Dungeon/CataclysmDungeonGameMode.hand.cpp, the dungeon game mode:TickrecordsBeatSeconds, the time the beat covered, before the wave-check accumulator resets, and clamps it to 1.0 s. The 79 uses of the fixed 0.25 s in the floor rules read it instead. The waves are unchanged.game/Source/Cataclysm/Tests/CataclysmDungeonModifierEffectsTests.cpp: three tests -- Mortal Decay's rate is the same at four and at two frames a second, a three-second frame costs one second, and Death's Embrace's clock counts the same at both frame rates.docs/DECISIONS.md: the entry and window w77's record.Evidence: window w77, at 3f6b0af on development c120310
BeatSecondsset back to 0.25 s): PROVED. With the break in,ABeatCountsItsOwnTimeSoMortalDecaySapsItsRateAtTwoFramesASecondfailed; restored, it passed.ABeatCountsAtMostOneSecondSoALongFrameCostsOneSecondOfMortalDecayfailed; restored, it passed.After the tested commit, only
docs/DECISIONS.mdchanged (the record).🤖 Generated with Claude Code