Repository navigation
skills: v6.6.3 catch-up - #18
Conversation
….toml config field that stops a node before executing a target block while continuing to serve RPC, with validation constraints against halt-height/halt-time, grpc-only, state sync, seed mode, and Autobahn. (sei-protocol/sei-chain#3978)
…PC requests to live and freeze-height-frozen nodes based on block number, plus a new `--freeze-height` flag on `seid start`. (sei-protocol/sei-chain#4024)
…e-depth CLI flag (default 16) to bound nested block reference parsing depth. (sei-protocol/sei-chain#4034)
…-limit and --write-timeout, to configure JSON-RPC batch size limits and HTTP response write timeouts. (sei-protocol/sei-chain#4048)
Checked against the sei-chain v6.6.3 tag: - freeze-height is a top-level app.toml key next to halt-height and halt-time; there is no [base] section (sei-cosmos/server/config/toml.go). - Freeze mode is full-node only: validator and seed modes are rejected too, not just seed (sei-tendermint/node/public.go). - Freeze mode is read-only from startup: tx and evidence broadcasts fail with "RPC writes are disabled in freeze mode", which also covers eth_sendRawTransaction. - The initial-height check allows freezing at the initial height itself. - frozen-rpc-router: rejoin the split flags table, cite sei-chain#4024, document "batch too large" (-32600) and the block-reference depth fallback, and scope Sei-RPC-Route to single-backend responses. - Link cli/frozen-rpc-router.md from SKILL.md and SKILL-ECOSYSTEM.md so flattened installs include it. Co-authored-by: Cursor <cursoragent@cursor.com>
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
|
Checked this against the sei-chain v6.6.3 tag and pushed the fixes in 91b572d. Verified as written: all seven Fixed:
Merges cleanly with |
PR SummaryLow Risk Overview Adds a new Extends Reviewed by Cursor Bugbot for commit 550c967. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
This docs-only catch-up for v6.6.3 adds --freeze-height to the seid CLI and node-operations references, plus a new frozen-rpc-router page. The "[base] section" error that the PR description flags as a failed verification is already fixed in the diff: every page now calls freeze-height a top-level app.toml key. Only one small doc inconsistency is left.
Findings: 0 blocking | 2 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- [suggestion] The PR description still has a '⛔ Failed final verification' section saying
freeze-heightis documented under a[base]section. The current diff already says it is a top-level key on all pages. Update or remove that section so reviewers aren't told to fix a problem that no longer exists. - 1 suggestion(s)/nit(s) flagged inline on specific lines.
Inline comments (could not post inline; listed here)
skill/references/cli/frozen-rpc-router.md:61(RIGHT) -- [suggestion] This sentence contradicts the list below it. It says the header is set on "responses served by a single backend", but themixedvalue is for a batch split across several backends. Reword it to something like "Responses carry aSei-RPC-Routeheader describing which backend(s) served the request". Also check against the router source thatmixedis really emitted, so the doc doesn't mislead people integrating against the header.
Reword the Sei-RPC-Route intro so it no longer contradicts the mixed value: the router sets the header on every forwarded response (frozen:<height> or live from proxy(), mixed for a batch split across backends), but not on errors it generates itself. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@seidroid review |
There was a problem hiding this comment.
This docs-only v6.6.3 catch-up is consistent across pages: freeze-height is called a top-level app.toml key everywhere, and the new frozen-rpc-router.md is linked from both SKILL.md and SKILL-ECOSYSTEM.md, so flattened installs will include it. The earlier Sei-RPC-Route header wording issue is fixed: the page now says the header describes "which backend(s)" served the response, which agrees with the mixed value.
Findings: 0 blocking | 0 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- None at the file/PR level.
alexander-sei
left a comment
There was a problem hiding this comment.
Verified against the sei-chain v6.6.3 tag (details in the comment above). seidroid's suggestions are addressed and its re-review on 550c967 found nothing; Bugbot is clean.
Skill catch-up for v6.6.3.
4 source PR(s) produced changes across 4 commit(s). Each source PR is a separate commit, so this reviews commit-by-commit.
skill/references/cli/seid-cli.md,skill/references/ecosystem/node-operations.mdskill/references/cli/frozen-rpc-router.md,skill/references/cli/seid-cli.mdfrozen-rpc-routerbinary that proxies EVM JSON-RPC requests to live and freeze-height-frozen nodes based on block number, plus a new--freeze-heightflag onseid start.skill/references/cli/frozen-rpc-router.mdskill/references/cli/frozen-rpc-router.md⛔ Failed final verification against the release tag
Each touched page was re-checked claim-by-claim against the
v6.6.3checkout after all commits were assembled. The items below contradict what actually ships at the tag and must be resolved before merging.skill/references/cli/seid-cli.md(Node Start (seid start) →--freeze-height, bullet: "Also settable via thefreeze-heightfield in the[base]section ofapp.toml") — The freeze height is also settable via thefreeze-heightfield in the[base]section ofapp.toml.freeze-height = {{ .BaseConfig.FreezeHeight }}inside the ManualConfigTemplate under the "Base Configuration" comment banner (toml.go:17-19), which is at the TOP LEVEL of app.toml with no[base]TOML section header. The first section header in the template is[state-sync](toml.go:77); grep for[base]in toml.go returns no matches. There is no[base]section in app.toml, so the key does not live under a[base]section.Reviewer notes
release/v6.6: Add freeze mode for historical EVM RPC sei-chain#3978 — The primary home for this change is node-operations.md, which already documents app.toml BaseConfig fields (halt-height is a natural sibling) and node startup/systemd usage. The seid-cli.md addition is a secondary/optional judgment call — that file focuses on wallet/query/tx subcommands and does not currently document 'seid start' flags at all, so a reviewer may prefer to keep the flag documentation solely in node-operations.md. No existing skill mentions halt-height, so this is net-new content in both cases.release/v6.6: Add frozen RPC router and Docker integration cluster (#3989) sei-chain#4024 — The--freeze-heightflag is already well-documented in both cli/seid-cli.md and ecosystem/node-operations.md, and the existing exclusive-boundary description ('settles at freeze-height - 1') matches the PR — so the freeze-height flag itself is largely covered and may only need a cross-reference to the new router. The genuinely new, undocumented artifact is thefrozen-rpc-routerbinary and its CLI flags, which no skill file mentions; a new reference file is the primary gap. Proposed path cli/frozen-rpc-router.md fits the existing cli/ category; alternatively it could live under ecosystem/ since it's an operational proxy tool — judgment call left to the reviewer.release/v6.6: Bound block reference parsing depth sei-chain#4034 — The change is a single new CLI flag on frozen-rpc-router, fully covered by the existing frozen-rpc-router.md skill. The flag bounds nested block-reference depth (e.g. EIP-1898 {"blockNumber": ...} objects); the router now returns an empty/unknown reference (routing to live) when depth exceeds the limit. A brief note on this routing behavior for over-deep references could also be added to the Routing behaviour section, but the primary gap is the missing flag entry. The seid-cli.md frozen-rpc-router mentions are only cross-references and need no change.release/v6.6: Bound frozen RPC router batch allocations sei-chain#4048 — The frozen-rpc-router skill file is the only place documenting this command. The Flags table needs the two new rows, and the 'Other error codes' section should note that batches exceeding --batch-request-limit are rejected with code -32600 and message 'batch too large'. No other skill files reference these flags.Flagged by a review of every touched page's final text. Each source PR was analysed in isolation, so these were invisible to the per-PR checks. Verify before merging — the checker cannot tell which side of a contradiction is correct.
Analyzing the pages for the specified issues.
--freeze-heightapp.toml section (seid-cli.md): The new text says freeze-height is settable via the[base]section ofapp.toml, while node-operations.md (and the router page) treat it consistently—but within seid-cli.md itself it's stated as[base], whereas node-operations.md saysBaseConfigsection "alongside halt-height / halt-time". These are two different section names ([base]vsBaseConfig) for the same field across the update, but not on the same page — noting only same-page issues: no direct same-page contradiction here.sei_traceBlockByNumberExcludeTraceFailremoval vssei2_*ExcludeTraceFailremaining (node-operations.md): The "Removed (as of Sei v6.6.0)" bullet says the twosei_*block-trace endpoints are removed and can no longer be enabled, but then states thesei2_*ExcludeTraceFailblock variants "all remain." Meanwhile thesei2_*namespace section lists "the*ExcludeTraceFailvariants" as gated/enable-able methods. This is consistent (sei_ removed, sei2_ remain), so not a contradiction.NONE
Generated by sei-docs-bridge. Every change is a proposal — verify against the source PRs before merging.