Repository navigation
Pin transport v0.2.0 - #2
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cargo install --tag follows a mutable ref: if v0.2.0 were moved, cold-cache runners would build different source under the same cache key. Build from the tag's commit 553bb45b8bfa3ac9c9f7ed1ad71a8ac19d384542 (git ls-remote refs/tags/v0.2.0) with --rev, and put the full SHA in the cache keys and install dirs. TRANSPORT_RELEASE keeps the release name visible. Runtime download pins are unchanged: tag v0.2.0 plus the pinned sha256.
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins transport v0.2.0, the first tagged release with
--stdio. Linear: SEL-115.CI now builds
transportandtransport-conformancefrom the v0.2.0 commit (--rev 553bb45) instead of commit44a9c7a. The static musl transport in the Linux platform wheel is built from the same tag. The README's build instructions match. No runtime code changes: the client takes its transport from the wheel,SELECTIVE_TRANSPORTor PATH, and never downloads it.Verification
retries_after_rejected_connects, is new in v0.2.0git grepfor old pins (44a9c7a,pr10-,v0.1.)CI's wheel job builds the musl transport from the tag and runs the installed wheel's
check_stdioon Alpine and Debian.test (3.14, newest)is red becausenewestnow resolves to pytest 9.2.0, which came out after main's last green run. main breaks the same way on 9.2.0: 14 failed, 53 passed, against 67 passed on 9.1.1. This PR changes no Python. Tracked in SEL-116.