Repository navigation
fix: enforce read-only connection mode and report the actual catalog - #33
Closed
vibeinging wants to merge 1 commit into
Closed
vibeinging wants to merge 1 commit into
vibeinging wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A connection opened with
access_mode=DSQL_MODE_READ_ONLYcurrently accepts the setting but reports mode 0 and permits a zero-row DELETE.current_catalogalso returns an empty string instead of the connected database name, causing downstream connection validation to fail.This change applies read-only mode before login succeeds, keeps that session pinned across autocommit changes, invalidates prepared bindings when the access mode changes, and closes the connection if read-only protection cannot be restored. The catalog getter now reads the actual database name and propagates query errors.
Validation on native macOS ARM64 / CPython 3.12 against a real DM8 instance:
The test report records the tested combinations and the separate pre-existing executemany limitation with the official C extension. This PR contains source and tests only; it does not distribute a vendor DPI SDK or compiled driver artifacts.