Repository navigation
Update nodejs to 26 - #1098
Merged
Merged
Update nodejs to 26#1098
Conversation
This is a bit more involved than just bumping the version number. First, the taskcluster client only supports one major version of node at a time, so it needs to be bumped at the same time. Second, in their infinite wisdom, the node people stopped shipping corepack and docker images dropped yarn along with it. The remaining options are vendoring 3MB of yarn in the repo, use npm to install corepack to install yarn (Yo dawg, I heard you liked package managers so I put a package manager in your package manager), or not using yarn anymore... We can sidestep this by using `yarn` from alpine right now. It's not ideal because it installs another node version with it and may or may not run on that (who knows...). It makes no difference in the end result, but I hate it... Thankfully `apk` isn't as bad and cleans up nicely on `apk del` so we don't end up with anything extra in the image.
jcristau
approved these changes
Nov 10, 2026
jcristau
left a comment
jcristau
left a comment
Contributor
There was a problem hiding this comment.
yuck.
And https://hub.docker.com/r/yarnpkg/node-yarn says "DEPRECATED as the Node.js Docker images now come with Yarn preinstalled" which is somewhat ironic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit more involved than just bumping the version number. First, the taskcluster client only supports one major version of node at a time, so it needs to be bumped at the same time. Second, in their infinite wisdom, the node people stopped shipping corepack and docker images dropped yarn along with it. The remaining options are vendoring 3MB of yarn in the repo, use npm to install corepack to install yarn (Yo dawg, I heard you liked package managers so I put a package manager in your package manager), or not using yarn anymore...
We can sidestep this by using
yarnfrom alpine right now. It's not ideal because it installs another node version with it and may or may not run on that (who knows...). It makes no difference in the end result, but I hate it... Thankfullyapkisn't as bad and cleans up nicely onapk delso we don't end up with anything extra in the image.Closes #1091