Repository navigation
Conversation
… tags The regex that adds rel/target to links matched any tag starting with "<a" and any attribute ending in "href=". So <area href=...> became <a rel="nofollow"rea href=...>, <abbr data-href=...> became a broken <a ...bbr> tag, and <a data-href=...> without an href got rel/target. Require whitespace after the tag name and a real href attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nofollowandtarget-blank-linksextras addrel/targetwith a regex that matches<afollowed by anything up tohref=. It has no word boundary on either side, so it also hits other tags and other attributes:The
<area>and<abbr>tags are turned into broken<a ...rea/<a ...bbrtags, and<a data-href="...">(no real href) also getsrel/target.Fix: require whitespace after the
atag name, and requirehref=to not be the end of a longer attribute name ((?<![\w-])).Test: new
test/tm-cases/link_nofollow_other_tags(<area>,<abbr data-href>,<a data-href>and a normal link, with both extras). It fails before the change and passes after.make testoneandmake testredospass.