Repository navigation
STEP TF turn structure - #4643
chris-ashe wants to merge 17 commits into
Conversation
|
| """Cross-sectional area of the stabiliser in the TF turn [m²]""" | ||
|
|
||
| n_tf_turn_superconducting_strands: int = 0.0 | ||
| """Number of superconducting strands in the TF turn""" |
| # Copper mass [kg] | ||
| self.data.tfcoil.m_tf_coil_copper = ( | ||
| m_tf_coil_copper = ( | ||
| self.data.tfcoil.len_tf_coil |
There was a problem hiding this comment.
When itart == 1 include the centre column length cplen is not included in len_tf_coil. This is accounted for else where or is copper the missing?
There was a problem hiding this comment.
This is true of all the masses in section. I can see some if statements for itart == 1. Also is it useful to list, list the copper masses, without the centre rod included? Are the centre rod masses/area calculated as well, we these will be needed for costing or other engineering models.
There was a problem hiding this comment.
Looking at tf_coil_shape_inner() the len_tf_coil is calculated as itart dependant
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4643 +/- ##
==========================================
- Coverage 50.94% 50.77% -0.17%
==========================================
Files 181 181
Lines 30406 30757 +351
==========================================
+ Hits 15490 15617 +127
- Misses 14916 15140 +224 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…or model handling and improve comments
… related calculations
…ingTFCoil for accurate critical current calculations
…nboard_peak_ripple_symmetric in SuperconductingTFCoil
…tions in STEPSuperconductingTFCoil
…add tf_cicc_areas_and_masses method for improved accuracy
…add tf_step_inboard_areas_and_fractions method for improved accuracy
…culations in CROCOSuperconductingTFCoil
…erconductingTFCoil to compute superconductor lengths
…essValueError in STEPSuperconductingTFCoil
…e unit tests for tf_cicc_areas_and_masses
465f636 to
e1b992b
Compare
e1b992b to
53b6618
Compare
| whttflgs = m_tf_coils_total * (self.data.tfcoil.len_tf_coil / tfleng_sph) | ||
| else: | ||
| whtcp = 0.0 | ||
| whttflgs = 0.0 |
There was a problem hiding this comment.
For the coil case you compute the mass with a else statement for the itart where as for the copper, superconductor and insulation you do not. Therefore you will double the mass contribution from the case in the centerpost with this final step.
Also for future work it would be good to also calculate the total copper mass counting for itart.
Also whtcp and whttflgs don't follow the variable style guide and are confusingly named.
| whttflgs = m_tf_coils_total * (self.data.tfcoil.len_tf_coil / tfleng_sph) | ||
| else: | ||
| whtcp = 0.0 | ||
| whttflgs = 0.0 |
There was a problem hiding this comment.
Same comment as for the STEP areas and masses function.
Description
This pull request adds support for a new "step-stacked tape" type to the superconducting toroidal field (TF) coil modeling, along with the necessary data fields and model registration. The changes ensure the new coil type is selectable, its parameters are tracked, and its model is properly invoked in the workflow.
Support for Step-Stacked Tape TF Coil:
STEPSuperconductingTFCoilto the imports and model registration inmain.py, and included it in the list of models for execution.caller.pyto call the newstep_sctfcoilmodel when theSTEP_STACKED_TAPEturn type is selected.3to thei_tf_turn_typechoices ininput.py.Checklist
I confirm that I have completed the following checks: