Repository navigation
dist: stop publishing source.tar.gz - #407
Merged
Merged
Conversation
dist builds it with git archive of the tag, so it carries the same files and contents as the tarball GitHub already serves for the tag. Fixes #405
oech3
reviewed
Nov 8, 2026
Comment on lines
+19
to
+21
| # No source.tar.gz. dist builds it with `git archive` of the tag, which is | ||
| # what GitHub already serves as the release's "Source code" download, so it | ||
| # only duplicated that (issue #405). |
Contributor
There was a problem hiding this comment.
Suggested change
| # No source.tar.gz. dist builds it with `git archive` of the tag, which is | |
| # what GitHub already serves as the release's "Source code" download, so it | |
| # only duplicated that (issue #405). | |
| # GitHub automatically generates tarball on the release page. |
TLDR
Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com>
Collaborator
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #405
Thanks @oech3 for spotting this.
Evidence. I downloaded both 0.6.0 tarballs, the release asset
source.tar.gzand GitHub'sarchive/refs/tags/0.6.0.tar.gz, and extracted them. Only the top directory name differs (uu_shadow-0.6.0/vsshadow-0.6.0/):diff -rof the two trees: no differencesChange.
source-tarball = falseindist-workspace.toml.dist generate --mode ciwith dist 0.34.0, run as CONTRIBUTING.md documents, leavesrelease.ymlunchanged. The source tarball is driven by the plan manifest, not the workflow.dist planbefore/after: the only lines that go aresource.tar.gzand[checksum] source.tar.gz.sha256. The JSON manifest diff is limited to those two artifacts. The gnu x86_64/aarch64 archives, the static musl archive andsha256.sumare unchanged.source.tar.gz.tests/verify-release.shchecks only the three named archives, and no PKGBUILD or doc uses it.Reviews welcome. Without objection, this will be merged after 7 days.