Repository navigation
fix(pages): skip static page-data requests in development - #710
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
output: "static", client navigation in development tries to fetch generated page-data files that the dev server does not serve:The page loads through the server fallback, but the failed request adds a network round trip. Prefetching follows the same path.
Cause
The shared Pages plugin passes
resolveStaticPageDataBuildOptions()to client generation in both development and production. That function enables static page data wheneveroutput === "static", although the JSON files are only generated during the production build.Fix
Pass
{ enabled: false, fastPath: false }when generating a development client. Production clients continue to use the existing build options, preserving static JSON fetching and routing-rule checks