Repository navigation
docs: correct file-defined scorer sampling default - #994
Merged
Merged
Conversation
warp-agent-staging
Bot
added
documentation
Contributor
Author
|
This PR was generated with Warp. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hongyi-chen
approved these changes
Nov 7, 2026
hongyi-chen
marked this pull request as ready for review
November 7, 2026 00:01
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the file-defined scorer
samplingRatedefault from25to10insrc/content/docs/factories/factory-as-code.mdx. The explicitsamplingRate: 25example is a valid override and stays unchanged.Evidence
The published scorer schema states “Defaults to 10” at
/properties/samplingRate/description. Implementation-default and public-release checks corroborate this narrow correction; private evidence is not reproduced here.This is a factual correction to an existing reference, so no content design plan is required. No headings, links, navigation, or surrounding prose change; the deletion-only review found nothing else within scope to remove.
Validation
Passed:
npm run typechecknpm run test:heading-varsnpm run buildnpm run test:heading-tocsnpm run test:homepage-json-ldpython3 .agents/skills/style_lint/style_lint.py --changed(warnings are identical to the base revision; none introduced).python3 .agents/skills/doc_quality_policy/check_compression_contract.py src/content/docs/factories/factory-as-code.mdx --content-type referencepython3 .agents/skills/check_for_broken_links/check_links.py --internal-onlygit diff --check origin/main...HEADThe dedicated live schema-coverage checker ran with findings, not a clean result. Full-reference completeness remains inconclusive: trigger catalogs moved to an owning page, runner value tables are not parsed, and a discovered schema lacks a checker mapping. Remaining nested-field diagnostics require triage rather than automatic documentation additions. Trunk is unavailable; external links and end-to-end runtime behavior were not tested.
Follow-ups
Review this independent correction. Separately repair checker mappings/extraction, rerun coverage, and finish availability/ownership review before broader edits. Supplementary comparison found no provider-event or opted-in value-catalog additions/removals to document. No single engineering owner resolved, so no reviewer was requested.
Unverified claims
No unverified claim is introduced by this diff. Broader runtime and release availability across all schema fields were not fully verified; this is not an exhaustive certification of the reference.
Documentation risk
Risk: engineering-review-required
Rationale: Corrects a documented configuration default; engineering confirmation is pending.
Engineering review status: pending
Docs override: none
Audit run details
Co-Authored-By: Oz oz-agent@warp.dev