Repository navigation
official units: comline@2's Rust type is under handshake::comline2 - #240
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime reorganization (ComlineProject/runtime#102) moved
comline_runtime::comline2tocomline_runtime::handshake::comline2. Two strings in core still named the old path for thecomline@2handshake's Rust type; both now readcomline_runtime::handshake::comline2::Comline2Handshake:core/src/encodings/official_units.json(the snapshot)core_stdlib/packages/comline/config.idp(the stdlib it is generated from; core's staleness test compares the two, so they change together)The other runtime paths core names (
contract::*,format::*,framing::JsonRpcFraming,handshake::ComlineHandshake) are unchanged.This lands first because generation, comline-rust, the CLI and the language server all pin core: they should bump to the commit this produces, rather than to #239 and then again.
Closes #218. Part of ComlineProject/runtime#111; follows #239.
Tested locally, as CI does:
cargo build;cargo test(all green, 326 lib + 645 + other integration tests)cargo test -p comline-core --features deps(all green, 350 lib + 657 + others)cargo test -p comline-core --no-default-features --lib(114 passed)