Repository navigation
show network bytes sent, received, and total - #44
Merged
Merged
Conversation
Append the already sampled counter strings to the networking list after IPv4. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The panic hook flushes diagnostics and captures a backtrace before the collector can publish the failure. Poll for 30 seconds so that report and the reinitialized follow-up can arrive. Co-authored-by: jameslincn <jameslincn@outlook.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The networking list already samples bytes sent, received, and total. Those formatted strings are now columns after IPv4.
-and is not shown as0.The collector-panic test still requires
ERROR_GEN_FAILUREwith an empty completion, then the coalesced follow-up value4after reinitialization. That report is published only after the panic hook flushes diagnostics and the default hook captures a backtrace (RUST_BACKTRACE=1in CI). The test now polls for 30 seconds, sleeping between attempts, so a loaded Windows runner can deliver both results.rustfmtandgit diff --checkpassed for the edited files. This Linux host still cannot finishcargo checkbecausellvm-rcis not installed.