Repository navigation
keep an unknown memory limit out of the history - #47
Merged
Merged
Conversation
A zero physical memory limit is a missing measurement, not an empty machine. Leave the previous memory history point in place, label the meter with the existing Not Available text, and still record a later real 0% sample when the limit is known. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing physical memory limit is not an empty machine.
apply_system_sampleused to turnphysical_mem_limit_kb == 0into 0% and push that point intomem_history.The new unit test sits next to the existing performance sample tests and covers both the unknown-limit case and a later real 0%.
Linux could not compile Windows resources here (
llvm-rcis not installed, and it was not added).cargo fmt --all -- --checkpassed.Testing
cargo fmt --all -- --checkcargo test --locked --bin taskmgr unknown_memory_limit_keeps_history_and_real_zero_still_recordsfailed in the resource build step becausellvm-rcis absent (No such file or directory). The performance-page change was not linked or executed on this host.