Repository navigation
keep an unknown GPU memory limit out of the history - #48
Merged
Merged
Conversation
A missing or zero dedicated or shared limit is not measured 0% usage. Leave the previous history point, and still record a real zero once a non-zero limit is available. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdapterHistory::pushtreated a missing or zero GPU memory limit as 0% usage.memory_percentagestill returns that clamp for the meter placeholder, but the history no longer stores it.Noneor0leaves the previous history point in place.memory_percentageis unchanged, includingmemory_percentage(1, None) == 0andmemory_percentage(1, Some(0)) == 0.Test
unknown_memory_limit_does_not_advance_historyseeds a real dedicated and shared point, checks that usage with no limit and usage with a zero limit do not move either series, then checks that a real zero with a real limit does.This environment cannot compile the Windows resource script (
llvm-rcis not installed), socargo testdid not run here.cargo fmt --all -- --checkpassed.